updated tools/release.js to use uglify-js 2.x #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2014 11:08
changed the package.json to look in the root, as with the rest of the file reads. changed the uglify function to use uglify.js 2.4.x's simpler minify api.
updated package.json to use uglifier-js 2.x
ghost
changed the title
sayrer
added a commit
that referenced
this pull request
Jun 8, 2014
updated tools/release.js to use uglify-js 2.x
|
thanks! |
ghost
deleted the
|
my pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some slight updates to the tools/release.js.
Updated the uglify(src,dst) function to use uglify-js 2.x's simpler api, using the minify function for parsing, compressing, and generating output code. There might be some reason why uglify-js 1.x is being used, but because the last update was 2 years ago, I just assumed it needed some love.
Also changed the file read of package.json to be looked for in the root, to be consistent with the rest of the file reads, as well as to build the bundled files on a Windows machine where one might not have access to make, figuring they are running node release.js from the tools directory (It also requires the creation of a dist directory, but that can be done manually.)