Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changed revert to right and bottom coordinates
Revert does not move back to the right coordinates. They x and y coordinates should be right and bottom, not top and left. This way the element moved snaps back to its exact original position, and not an offset position.
- Loading branch information
7d1cee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change has been made my revert no longer works.
If I change the line back to using "left" and "top" then everything works fine again.
7d1cee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inversiondk
@johnpmitsch Mind looking into that?
7d1cee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inversiondk @briangonzalez Thanks for the heads up, I'll look into it today
7d1cee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@briangonzalez @inversiondk I figured out that the revert does not work correctly when place: false option is added, which I needed so my div's do not stack on top of one another.
adding something on 685 like this fixes the issue. I'll submit a pull request
7d1cee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get #163 merged then?